Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Config Ignore Module. #110

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Adding Config Ignore Module. #110

merged 2 commits into from
Jun 9, 2020

Conversation

acidaniel
Copy link
Contributor

JIRA Ticket(s)

Description

  • Adding Config Ignore Module to the skeleton.

Testing instructions

  1. Ensure that config_ignore module is added to the default skeleton when create a new project

Pull Request Guidelines

@acidaniel acidaniel requested a review from byrond June 2, 2020 18:57
byrond
byrond approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@byrond byrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have a s a suggestion for now. Maybe we can add it as a requirement with some default configuration later.

@byrond byrond merged commit a8511f0 into develop Jun 9, 2020
@byrond byrond deleted the DMS-34-Config-Ignore-Module branch June 9, 2020 15:31
@byrond byrond mentioned this pull request Jun 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrond byrond byrond approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acidaniel @byrond