Use PHP 8 #127
Merged
Use PHP 8 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
becw
commented
Oct 7, 2022
•
becw
commented
- Use PHP 8.1 on CircleCI
- Use PHP 8.1 in ddev
- Is there other code in here that needs updating for PHP 8?
|
Full support for PHP 8 requires Drush 11 (officially) which requires Devel 5, so we should probably account for that. |
Hmm, Composer doesn't enforce this dependency... when I install palantirnet/drupal-skeleton now it installs Drush 11.2.1 and Devel 4.2.1. So this must be like a verbal/documented dependency and not a technical dependency? |
|
I found that the only constraint on the Devel version was... our own composer.json file. So I removed the upper bound on that in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.