Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dev caching settings to settings.local.php and services.local.yml #129

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

becw
Copy link
Member

@becw becw commented Oct 24, 2022

Move dev caching settings to settings.local.php and services.local.yml to make them easier to turn on and off.

On wisdhs-workweb, we found it difficult to test caching locally because we had to dig around for the appropriate settings to mess with to have local be configured like prod. This moves those settings into local specific config files, so that devs can enable/disable easily.

Copy link
Contributor

@byrond byrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, with this we are switching local dev caching on by default (if the developer chooses to switch it on in the Drupal UI). I'm wondering if the Disable caching. lines should be commented out at the start, so there isn't a change in functionality (or expected behavior) just by copying the .local files. Same question with the aggregation setting lines.

Also, this divides local settings into two different files when using DDEV. Should we consider moving the error level and test module setting lines to settings.local.php, so they can all be found in one place?

@byrond byrond added the question label Jan 4, 2023
@becw
Copy link
Member Author

becw commented Jan 4, 2023

Also, this divides local settings into two different files when using DDEV. Should we consider moving the error level and test module setting lines to settings.local.php, so they can all be found in one place?

The reason I did this is because IMO some development settings should be shared between all development environments -- specifically, the error level. I want it to be a pain in the butt for us to turn off error reporting on our local environments! There are too many times when I've seen folks working with error reporting turned off because it's off by default, leading to PHP warnings and deprecation notices that are easy to fix now, and hard to fix later.

Is that too paternalistic? :)

@byrond byrond merged commit a972198 into develop Jan 5, 2023
@byrond byrond deleted the easier-dev-caching branch January 5, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants