Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-45: Prevent 404 error in the-build-installer by updating acquia memcache install task #149

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

jesconstantine
Copy link
Contributor

@jesconstantine jesconstantine commented Jul 13, 2023

User story: DEV-45: 404 error on install in request for Acquia memcache config file

Description

This PR updates the process for adding memcache to an acquia project based on https://docs.acquia.com/cloud-platform/performance/memcached/enable/#configuration-for-drupal-9-or-later

  • it points to a version of the-build with updated phing tasks during the-build-installer
  • adds a suggestion package to composer.json

Testing instructions

  1. Pull this branch down
  2. Run composer create-project palantirnet/drupal-skeleton memcache dev-update-acquia-memcache-setup
  3. Edit memcache/.ddev/config.yaml to change the site name
  4. Run ddev start
  5. Run ddev ssh
  6. Run the-build installer vendor/bin/the-build-installer and make sure you choose acquia as the host provider
  • Observe the installer completes successfully
  • You should not have a failure because of a 404 error on an HTTP request
    image
  • There should be no docroot/sites/default/cloud-memcache-d8+.php file
    image
  • The project's composer.json should include a require dependency: drupal/memcache
    image
  • The project's composer.json should include a suggest dependency: acquia/memcache-settings with a link to the documentation and not to update settings for Cloud Platform (vs Cloud Next) projects.
    image

Remaining tasks

  • Roll back change pointing to our branch for the-build in composer.json

@jesconstantine jesconstantine changed the title Add composer suggestion for acquia memcache settings with docs DEV-45: Prevent 404 error in the-build-installer by updating acquia memcache install task Jul 13, 2023
@jesconstantine jesconstantine marked this pull request as ready for review July 13, 2023 16:36
@jesconstantine jesconstantine self-assigned this Jul 13, 2023
@jaymejohnson
Copy link
Contributor

@jesconstantine I got an error running ddev start

Error response from daemon: driver failed programming external connectivity on endpoint ddev-drupal-skeleton-chrome (7e57db257e4687eea623222cef79af374bf07105cf039d220770d92e9346d618): Bind for 0.0.0.0:9222 failed: port is already allocated' 

It's headless chrome that's throwing the error:
Screenshot 2023-08-03 at 1 07 18 PM

Any ideas what I might be doing wrong?

Copy link

@tbower89 tbower89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying ddev start I wat met with this error.

tessa@Tess-Mess drupal-skeleton % ddev start
Starting drupal-skeleton... 
ddev version v1.21.6
Container ddev-drupal-skeleton-db  Recreate 
Container ddev-drupal-skeleton-solr  Running 
Container ddev-drupal-skeleton-dba  Running 
Container ddev-drupal-skeleton-web  Recreate 
Container ddev-drupal-skeleton-web  Recreated 
Container ddev-drupal-skeleton-db  Recreated 
Container ddev-drupal-skeleton-db  Started 
Container ddev-drupal-skeleton-web  Started 
Error response from daemon: driver failed programming external connectivity on endpoint ddev-drupal-skeleton-chrome (bb48c03b58530a2d9bc2cab5d22afa046d6fce1c1bade16f5c2cb2670642056b): Bind for 0.0.0.0:9222 failed: port is already allocated 
Failed to start drupal-skeleton: ComposeCmd failed to run 'COMPOSE_PROJECT_NAME=ddev-drupal-skeleton docker-compose -f /Users/tessa/Desktop/sites/drupal-skeleton/.ddev/.ddev-docker-compose-full.yaml up --build -d', action='[up --build -d]', err='exit status 1', stdout='#1 [drud/ddev-dbserver-mysql-5.7:v1.21.5-drupal-skeleton-built internal] load .dockerignore
#1 transferring context: 2B done
#1 DONE 0.0s

#2 [drud/ddev-dbserver-mysql-5.7:v1.21.5-drupal-skeleton-built internal] load build definition from Dockerfile
#2 transferring dockerfile: 649B done
#2 DONE 0.0s

#3 [drud/ddev-dbserver-mysql-5.7:v1.21.5-drupal-skeleton-built internal] load metadata for docker.io/drud/ddev-dbserver-mysql-5.7:v1.21.5
#3 DONE 0.0s

#4 [drud/ddev-dbserver-mysql-5.7:v1.21.5-drupal-skeleton-built 1/2] FROM docker.io/drud/ddev-dbserver-mysql-5.7:v1.21.5
#4 DONE 0.0s

There was more after, but it is a bit too much to paste into a comment here.

@becw
Copy link
Member

becw commented Aug 16, 2023

This change worked fine for me and behaved as expected. I followed the testing instructions as written.

However, some of these changes should be merged and others shouldn't. So I'm going to go approve the PR on the-build and get that merged first :)

@becw
Copy link
Member

becw commented Aug 16, 2023

I've merged palantirnet/the-build#226; what remains here is to get that change included in a release.

@becw becw merged commit d6d2ffd into develop Aug 17, 2023
@becw becw deleted the update-acquia-memcache-setup branch August 17, 2023 14:42
@becw
Copy link
Member

becw commented Aug 17, 2023

@jaymejohnson and @tbower89 -- I think in your testing you probably skipped step 3:

  1. Edit memcache/.ddev/config.yaml to change the site name

... since the container names in your pasted output still included drupal-skeleton, and I'm guessing you have another ddev named drupal-skeleton running somewhere. If you changed the site name to something else (e.g. dev-45 or acquia-memcache or foo) then I think it would have resolved that conflict :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants