Use Drush 9 #70
Merged
Use Drush 9 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hp/phing-drush-task drush dependency is fulfilled.
…onfig_installer, and drupal/console. In addition to using the newer code for these packages, this allows the dependencies to be compatible with Drupal 8.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates composer dependencies so that they are compatible with Drupal 8.4's dependencies.
Drush 8 is not compatible with Drupal 8.4 (
drupal/core:8.4.0) -- the Drush 9 update is required. However, thecontinuousphp/phing-drush-taskpackage declares a dependency on Drush6.5 - 8.1, which prevents the Drush update (and therefore the Drupal 8.4 update). To work around this, we require Drush 9 but alias the version to 8.1, so that it fulfills both the Drupal 8.4 requirements AND thecontinuousphp/phing-drush-taskrequirements.I prefer this approach to using a forked repo for
continuousphp/phing-drush-task(weitzman, froboy), since we can reference the original repository and receive updates from there once they eventually come through.Unfortunately, Drush usage has changed significantly between Drush 8 and 9, since Drush is now built on
symfony/console. This means thatpalantirnet/the-buildandcontinuousphp/phing-drush-taskneeded updates too.