Update composer.json for Drupal 8.8 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it is broken -- drupal/core-composer-scaffold seems to be looking in palantirnet/drupal-skeleton for the .htaccess file.
…port managing dependencies' scaffolding files.
becw
force-pushed
the
composer-changes-for-drupal-8.8
branch
from
7afaf92 to
7963abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the composer.json to use the new
drupal/core-composer-scaffoldpackage.@see slides from Drupalcon Amsterdam and the drupal/core-composer-scaffold README.
This new scaffolding tool doesn't allow you to manage scaffolding files from your dependencies beyond saying "yes", "no", or "append". So, for the .htaccess file, which we want Drupal core to install but not update, we have to reference its full path as if it belongs to our project.
There's a Drupal core issue on the scaffolding behavior, which allows Drupal core to predictably handle user modifications to scaffolded files: https://www.drupal.org/project/drupal/issues/3092563. It looks like this fix will NOT be included in the 8.8.0 release, which means that we should manage the
.htaccessfile ourselves for the time being.