Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL-52: Address Domain Mismatches #12

Closed
wants to merge 2 commits into from

Conversation

damontgomery
Copy link
Contributor

JIRA Ticket(s)

Description

The demo site was not listing results correctly because two Drupal sites (single / domain access) were using the same configuration and because some of the domains in configuration were incorrect.

  • Use the fs-demo domain for all sites and use different subdomains.
  • Create a config split for the Domain Access solr index so that the site name can be different. See field_settings.site_name.configuration.site_name.
  • Create a config split for the Domain Access solr settings so that the hash can be different. Otherwise the document keys are the same and overwrite each other. See site_hash.
  • Update the build order to allow config overrides for Domain Access to take into affect and avoids overwriting of Solr documents because of identical IDs.

Testing instructions

  1. Install the site per the normal direction, phing build install-all.
  2. Go to a sample search page and search for a Drupal 8 term, pasta, http://d8.fs-demo.local/search-app?search=pasta. Confirm that an entry shows up for the single site and for the domain access site. Confirm that the images and links work.
  3. Search for a D7 term, ex, http://d8.fs-demo.local/search-app?search=ex. Confirm that the entry shows up, that the URL / Image shows up and try the link.

Relevant Screenshots/gifs:

example


Pull Request Guidelines

- Use the `fs-demo` domain for all sites and use different subdomains.
- Create a config split for the Domain Access solr index so that the site name can be different. See `field_settings.site_name.configuration.site_name`.
- Create a config split for the Domain Access solr settings so that the hash can be different. Otherwise the document keys are the same and overwrite each other. See `site_hash`.
This allows config overrides for Domain Access to take into affect and avoids overwriting of Solr documents because of identical IDs.
@agentrickard
Copy link
Contributor

THis has been fixed in later releases.

@agentrickard agentrickard deleted the feature/PL-52-address-domain-mismatches branch January 24, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants