Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL-6: Generalize the Search API fields #3

Merged
merged 6 commits into from
Sep 19, 2018

Conversation

Kbentham
Copy link
Contributor

@Kbentham Kbentham commented Aug 6, 2018

JIRA Ticket(s)

Description

Update config to correspond with updates to the search_api_federated_solr module.

Testing instructions

  1. use composer to checkout the PL-6-generalize-search-api-fields branch from the search_api_federated_solr module. Or update to master if the branch has been merged.
  2. checkout the search_api_field_map module.
  3. phing build install
  4. test module to ensure everything works and no errors are thrown.

Remaining tasks

  • update composer to point at the right version of the search_api_federated_solr module when PL-6-generalize-search-api-fields has been merged.
  • Split this new sub module into its own project.

Pull Request Guidelines

@froboy
Copy link
Contributor

froboy commented Aug 27, 2018

I was able to test palantirnet/search_api_federated_solr@2bb6bff by running composer require palantirnet/search_api_federated_solr:dev-PL-6-generalize-search-api-fields.

I tried rebuilding the site with phing build install and got the following:

[drush] Error: Class 'Drupal\search_api_federated_solr\Plugin\search_api\processor\Property\FederatedFieldProperty' not found in Drupal\search_api_federated_solr\Plugin\search_api\processor\FederatedFields->getPropertyDefinitions() (line 41 of /var/www/federated-search-demo.local/web/modules/contrib/search_api_federated_solr/src/Plugin/search_api/processor/FederatedFields.php).

I need to jump to some other tickets, so @Kbentham would you be able to check this out? I'm assuming the config needs to be rebuilt with the new module... it might work to build without the dependencies, then run the composer require above and see if it'll update, but you also might need to rebuild some of the config from scratch. Lmk if this doesn't make sense.

@froboy
Copy link
Contributor

froboy commented Sep 19, 2018

Looks like it's all good now. Thanks @Kbentham!

@froboy froboy merged commit 8d27a7f into master Sep 19, 2018
@froboy froboy deleted the PL-6-generalize-search-api-fields branch September 19, 2018 19:30
@ibakayoko ibakayoko mentioned this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants