Rewire CSS to use new classes and clean up. #31
Conversation
There was a problem hiding this comment.
@nstriedinger Thanks for your updates. Are these changes just a result of swapping out element selectors for the classes you've added? Curious about what seems to be rearranging / copy/pasting too?
| fill: $white; | ||
| display: block; | ||
| .search-pager__item.not-active .search-pager__item-link { | ||
| display: none; |
There was a problem hiding this comment.
@nstriedinger can you walk me through this change? Is this just a result from copy/pasting?
There was a problem hiding this comment.
@jesconstantine this is just like the original file. I just tried to organize it so it would be easy to grok through.
|
|
||
| @include breakpoint($bp0) { | ||
| display: inline-block; | ||
| height: 1em; |
There was a problem hiding this comment.
@nstriedinger can you walk me through this change too? Does this just happen to look like a change in the css rule because of how things were rearranged or is an actual change?
| .search-pager__item.not-active { | ||
| display: inline-block; } } | ||
| .search-pager__item-link svg { | ||
| height: 1em; } } |
There was a problem hiding this comment.
@nstriedinger can you walk me through this change too? Does this just happen to look like a change in the css rule because of how things were rearranged or is an actual change?
nstriedinger
changed the title
|
Thanks for the updates @nstriedinger - I think this will make implementation smoother for themers |
We shouldn't over-style in this base module.