FS-52: Testing keyword search

[russom-woldezghi]

Ticket

FS-52: Testing Keyword Search

Description

• Adds text keyword search (for autocomplete disabled) test coverage
• Test search using the word "Terrier", expects 4 result items and 1 pager page generated.

Testing instruction

• Pull down code
• Remove node_modules directory
• Run yarn install && yarn start
• Run yarn cypress to start Cypress electron binary. This will open another app to run test.
• Click on "Run all specs", this will open a Chrome to run all the steps.
• Verify tests are running and all tests pass.

Open question

• I had to add an extra space character in the text field, because it was for some reason cutting off the first "T" of "Terrier" not sure if that is intended here but wanted to flag that.

[biz123]

@russom-woldezghi I retested this yesterday after destroying my vagrant and provisioning it again. I now get 2 results consistently on all sites including this one, so I think 2 might be correct. Can you verify with the current demo environment?

[agentrickard]

I get 5.

[biz123]

My result matches this

[biz123]

In app tests I'm getting a failure for in the check for .fs-search-accordion__group-item

[biz123]

I should add that when I run the behat tests within the federated search demo I get test fails there as well, so I may still need to fix something on that end.

[biz123]

@russom-woldezghi I am going to test again after resolving the issues where Behat tests were failing.

[biz123]

@russom-woldezghi after troubleshooting my demo environment with @agentrickard I now have 5 results for terrier, so I've gone from too few (2 before) to too many (test expects 4). I'm still also getting a fail on the test for .fs-search-accordion__group-item.

[biz123]

[russom-woldezghi]

The issue introduced was that I was missing a site index and was resulting in 4 not 5 results for the word "Terrier".

I wasn't able to reproduce the error with .fs-search-accordion__group-item class missing.

I will look into the hook registry issue Ken called out during scrum, just to make sure the error with .fs-search-accordion__group-item is not related.