Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security updates #85

Merged
merged 14 commits into from
Jan 8, 2021
Merged

Security updates #85

merged 14 commits into from
Jan 8, 2021

Conversation

byrond
Copy link
Collaborator

@byrond byrond commented Jan 5, 2021

Notes

Testing

  cors.config:
    enabled: true
    # Specify allowed headers, like 'x-allowed-header'.
    allowedHeaders: ['*']
    # Specify allowed request methods, specify ['*'] to allow all possible ones.
    allowedMethods: ['*']
    # Configure requests allowed from specific origins.
    allowedOrigins: ['*']
    # Sets the Access-Control-Expose-Headers header.
    exposedHeaders: false
    # Sets the Access-Control-Max-Age header.
    maxAge: false
    # Sets the Access-Control-Allow-Credentials header.
    supportsCredentials: false
  • Create .eslintignore in the root of this project with * as its contents.
  • Create .env.local.js from the example file, and update the hostname:
hostname: "d8.fs-demo.local",
  • yarn start
  • Test the search and facets to verify you see the expected results.

dependabot bot and others added 8 commits June 6, 2020 13:50
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot[bot] <[email protected]>
…proxy-1.18.1

Bump http-proxy from 1.18.0 to 1.18.1
…tic-6.5.3

Bump elliptic from 6.5.2 to 6.5.3
…cket-extensions-0.1.4

Bump websocket-extensions from 0.1.3 to 0.1.4
@byrond byrond added the Work in-Progress Do not merge PR, currently being worked on. label Jan 5, 2021
@byrond byrond self-assigned this Jan 5, 2021
@byrond byrond added Ready for Review and removed Work in-Progress Do not merge PR, currently being worked on. labels Jan 5, 2021
@agentrickard
Copy link
Contributor

agentrickard commented Jan 5, 2021

I now have these:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.eslintcache
	.eslintignore

@byrond
Copy link
Collaborator Author

byrond commented Jan 5, 2021

@agentrickard I added .eslintcache to .gitignore. I am leaving .eslintignore out, since we may need to add one later.

Copy link
Contributor

@agentrickard agentrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests correctly both with and without the proxy enabled.

@agentrickard
Copy link
Contributor

@byrond are you doing the linting in this branch or another?

@byrond
Copy link
Collaborator Author

byrond commented Jan 8, 2021

@agentrickard I'm creating a new branch for fixing the linting errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants