Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds functionality to test for date fields with a start and end date #10

Closed
wants to merge 2 commits into from

Conversation

patrickfweston
Copy link
Contributor

This pull request accompanies the following issue: #11

This pull request fixes the issue by checking the value returned by the date field function to see if it is an array. If it is an array, both the start and end date are checked to match the value.

@becw
Copy link
Member

becw commented Dec 14, 2015

This branch and PR need to be based off of master, since experimental won't be merged back in there--it's just a placeholder for the other open branches.

@patrickfweston
Copy link
Contributor Author

@becw : Since my codebase in the project I made this fix for is based off of experimental, should I checkout master for the project and then make the changes? Otherwise, it will be akin to merging in experimental when this PR is merged.

@becw
Copy link
Member

becw commented Dec 14, 2015

Yes, you should cut a fresh new branch off of master. You should be able to do:

git checkout master
git checkout -b some-new-branch
git cherry-pick fccca32^..56c907c

@patrickfweston patrickfweston deleted the date-time-start-end branch December 14, 2015 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants