Add support for loading nodes, fields, and paragraphs. #34

damontgomery · 2018-05-29T18:12:28Z

Nodes can be loaded by type / title / language.
Fields can be loaded.
Entity references are loaded.
Special handling is used for fields with "nothing" values, they are checked to see if they are empty.

Special handling for:

Entity references which includes nodes, terms, media
Long text
Date (not yet ranges)
Links
Translations
Paragraph types in fields
Fields on paragraphs

Example:

Scenario: Blog post exists
  When I examine the "blog_post" node with title "My post"
  Then entity field "field_simple_example" should contain "test"
  And entity field "field_is_a_thing" should contain "nothing"
  # Example entity reference
  And entity field "field_authors" should contain "John Smith"
  And paragraph field "field_paragraphs" should be of type "my_paragraph_type"

Scenario: Paragraph fields
  When I examine the "page" node with title "My page"
  And I examine paragraph "5" on the "field_paragraphs" field
  Then entity field "field_content" should contain "Example"

Scenario: Paragraph fields in English
  When I examine the "page" node with title "My page" in "en"
  And I examine paragraph "5" on the "field_paragraphs" field
  Then entity field "field_content" should contain "Example"

Nodes can be loaded by type / title. Fields can be loaded. Entity references are loaded. Special handling is used for fields with "nothing" values, they are checked to see if they are empty. Example: ``` Scenario: Blog post exists Given I examine the "blog_post" node with title "My post" Then entity property "title" should be "My post" And entity field "field_simple_example" should contain "test" And entity field "field_is_a_thing" should contain "nothing" # Example entity reference And entity field "field_authors" should contain "John Smith" ```

…o get.

damontgomery · 2018-05-29T18:22:39Z

Going to work on this a little more.

Since properties and fields are accessed the same way.

After testing on more examples.

Fix docs around input parameters Add docs for $currentEntity

The default seems to be `name` rather than `title` which is used for nodes.

Paragraphs don't have titles, but we can check the type. A new pattern has been added. Paragraphs are entity references, so we throw an error when the general field pattern is being used since we aren't checking for value / title.

damontgomery · 2018-05-30T19:39:00Z

I missed out on the shared node extension. :(

This was needed before, but I forgot to export it.

Can be used like this ``` When I examine the "page" node with title "My page" And I examine paragraph "5" on the "field_paragraphs" field Then entity field "field_content" should contain "Example" ```

damontgomery · 2018-06-05T16:25:58Z

Added support for loading paragraphs.

This reverts commit d4f733b.

damontgomery · 2018-06-19T15:25:01Z

I've included the link work in #35 and also added support for translations.

becw

I've done a visual review of the code here -- is there any additional way you'd like me to test this?

BTW, the paragraph handling you added is pretty cool!

becw · 2018-06-26T15:45:51Z

src/Palantirnet/PalantirBehatExtension/Context/EntityDataContext.php

@@ -340,43 +399,66 @@ public function assertNotEntityFieldValue($field, $value)

    }//end assertNotEntityFieldValue()

+    /**
+     * Verify that a field contains a value.


I think this line of the comment is not accurate?

Thanks, I'll update this.

becw · 2018-06-27T12:48:22Z

src/Palantirnet/PalantirBehatExtension/Context/EntityDataContext.php

+
+                switch ($entity->getEntityTypeId()) {
+                    case 'node':
+                        $title = $entity->title->value;


Can you use $entity->label() here instead of relying on local logic for finding entity labels?

Also, I don't think Paragraph entities will come up here, since they are referenced by the "Entity Reference Revisions" field type, rather than the "Entity Reference" field type.

... ah, except for the assertEntityFieldValueEntityReferenceRevisions methods below! I see.

Thanks, I should be able to use $entity->label() for everything but paragraphs (their label isn't useful). I can update this and it should be a little clearer.

becw · 2018-06-27T12:53:26Z

src/Palantirnet/PalantirBehatExtension/Context/SharedDrupalContext.php

-            return node_load($nid);
-        } else if (empty($entities['node']) === false && count($entities['node']) > 1) {
+            return $node;
+        } else if (count($entities) > 1) {


I think this condition won't ever be hit, even when it should be -- the logic above seems to load and return the first nid in the array, regardless of whether the array has more than one result. Is this accurate?

Line 51 has if (count($entities) === 1) {, so the node will only be loaded if there is a single match. I've definitely hit this many times during tested and used a different node for testing. The logic is from the D7 version and I think it makes sense since there is no good way to know which node to use.

I think some of the confusion is that $nid = array_shift($entities); is used to get the first element. I think the keys are node IDs, so $entities[0] may not work but array_keys($entities)[0] would if that is clearer.

- Update paragraph assert method description. - Replace switch statement with generalized `$entity->label()`. - Add comment around node loading logic.

damontgomery · 2018-06-27T14:25:52Z

@becw,

Thanks for the feedback. I've made the updates you requested. This has been working for us on our project. Please let me know if you want to see some of it in detail on our project.

I'm good with the code as a first version.

If it looks good, do you want to merge it?

damontgomery requested a review from becw May 29, 2018 18:14

Exclude field name since the step already states it and it's harder t…

3cf98ae

…o get.

damontgomery closed this May 29, 2018

damontgomery added 9 commits May 30, 2018 10:49

Use one method for properties and fields.

7f9e141

Since properties and fields are accessed the same way.

Handle field values better.

6792658

After testing on more examples.

Remove termreference since all entity references are shared in D8.

d91624a

Handle different types of entity references.

e150136

Fix docs around input parameters Add docs for $currentEntity

Update functions since we pass field as an object.

69014fc

Add support for long text.

d2b8892

Add very basic support for date comparisons.

3723256

Handle media file references.

3aba751

The default seems to be `name` rather than `title` which is used for nodes.

Handle paragraph fields

c25f9ed

Paragraphs don't have titles, but we can check the type. A new pattern has been added. Paragraphs are entity references, so we throw an error when the general field pattern is being used since we aren't checking for value / title.

damontgomery reopened this May 30, 2018

damontgomery closed this May 30, 2018

Update node lookup method.

9d38fb9

This was needed before, but I forgot to export it.

damontgomery reopened this May 30, 2018

Add paragraph examine step.

2ed17e9

Can be used like this ``` When I examine the "page" node with title "My page" And I examine paragraph "5" on the "field_paragraphs" field Then entity field "field_content" should contain "Example" ```

damontgomery changed the title ~~Add support for loading nodes and fields.~~ Add support for loading nodes, fields, and paragraphs. Jun 5, 2018

Link URL field behat context testing

7d0ec83

russom-woldezghi mentioned this pull request Jun 12, 2018

Adds testing for URI value for link fields #35

Closed

Russom Woldezghi and others added 3 commits June 12, 2018 16:32

Updating composer.json

d4f733b

Revert "Updating composer.json"

97279ea

This reverts commit d4f733b.

Add support for testing translations, including paragraph translations.

90669a2

damontgomery assigned becw Jun 26, 2018

becw reviewed Jun 27, 2018

View reviewed changes

becw assigned damontgomery and unassigned becw Jun 27, 2018

Address review feedback.

9d3bbe5

- Update paragraph assert method description. - Replace switch statement with generalized `$entity->label()`. - Add comment around node loading logic.

damontgomery force-pushed the feature/entity-context branch from 93e4791 to 9d3bbe5 Compare June 27, 2018 14:23

becw merged commit 9708647 into palantirnet:drupal8 Jun 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for loading nodes, fields, and paragraphs. #34

Add support for loading nodes, fields, and paragraphs. #34

damontgomery commented May 29, 2018 •

edited

Loading

damontgomery commented May 29, 2018

damontgomery commented May 30, 2018

damontgomery commented Jun 5, 2018

damontgomery commented Jun 19, 2018

becw left a comment •

edited

Loading

becw Jun 26, 2018

damontgomery Jun 27, 2018

becw Jun 27, 2018

becw Jun 27, 2018

damontgomery Jun 27, 2018

becw Jun 27, 2018

damontgomery Jun 27, 2018

damontgomery commented Jun 27, 2018

Add support for loading nodes, fields, and paragraphs. #34

Add support for loading nodes, fields, and paragraphs. #34

Conversation

damontgomery commented May 29, 2018 • edited Loading

damontgomery commented May 29, 2018

damontgomery commented May 30, 2018

damontgomery commented Jun 5, 2018

damontgomery commented Jun 19, 2018

becw left a comment • edited Loading

Choose a reason for hiding this comment

becw Jun 26, 2018

Choose a reason for hiding this comment

damontgomery Jun 27, 2018

Choose a reason for hiding this comment

becw Jun 27, 2018

Choose a reason for hiding this comment

becw Jun 27, 2018

Choose a reason for hiding this comment

damontgomery Jun 27, 2018

Choose a reason for hiding this comment

becw Jun 27, 2018

Choose a reason for hiding this comment

damontgomery Jun 27, 2018

Choose a reason for hiding this comment

damontgomery commented Jun 27, 2018

damontgomery commented May 29, 2018 •

edited

Loading

becw left a comment •

edited

Loading