Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL-34 Add module schema and settings #40

Merged
merged 6 commits into from
Sep 21, 2018
Merged

Conversation

Kbentham
Copy link
Contributor

@Kbentham Kbentham commented Aug 9, 2018

https://palantir.atlassian.net/browse/PL-34
Add schema and default settings config to module.
Install the config inspector module and verify that the schema matches the config.

Check out palantirnet/federated-search-demo#5 and use compose to install this branch to test.

@agentrickard
Copy link
Contributor

++

@froboy
Copy link
Contributor

froboy commented Aug 13, 2018

@Kbentham I'm seeing some errors when I pull this up on http://federated-search-demo.local/admin/config/development/configuration/inspect. It looks like there are some schema mismatches on the fields and index. I'm seeing errors in these files:

  • core.entity_form_display.taxonomy_term.recipe_category.default (related to federated terms)
  • core.entity_form_display.taxonomy_term.tags.default (same)
  • field.storage.taxonomy_term.field_federated_terms
  • search_api.index.federated_search
  • search_api_federated_solr.search_app.settings
    Please try to resolve these errors or let me know if that's not possible.

@Kbentham
Copy link
Contributor Author

It looks like the schema system include a bit of type checking so i did not include that in the form validation.

@froboy
Copy link
Contributor

froboy commented Sep 21, 2018

Okey doke. Everything is split up and this is reading clean. 🎉

@froboy froboy merged commit 1183cc1 into master Sep 21, 2018
@froboy froboy deleted the PL-34-schema-settings branch September 21, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants