Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX-umus-21-update-urls-sitename-index #49

Merged
merged 4 commits into from
Sep 25, 2018

Conversation

mcarmichael21
Copy link
Contributor

@mcarmichael21 mcarmichael21 commented Sep 14, 2018

Description

D8 Version

Changed site_name to multi-value index field and added urls preprocessor.

@mcarmichael21 mcarmichael21 self-assigned this Sep 14, 2018
@mcarmichael21 mcarmichael21 changed the title update d8 urls and sitename indexing to match d7 HOTFIX-umus-21-update-urls-sitename-index Sep 14, 2018
@Kbentham
Copy link
Contributor

This works great. My only issue is that #39 was just merged and I think this might actually belong in the Search API Field Map module. https://github.com/palantirnet/search_api_field_map

@mcarmichael21
Copy link
Contributor Author

@Kbentham so I need to break off the preprocessor to search_api_field_map and pull master into this branch?

Copy link
Contributor

@Kbentham Kbentham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kbentham Kbentham merged commit 4fb32a9 into master Sep 25, 2018
@Kbentham Kbentham deleted the HOTFIX-umus-21-update-urls-sitename-index branch September 25, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants