forked from HuygensING/solr-faceted-search-react
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root-198: add search-as-you-type suggestion query functionality #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2019
This will also enable boosting
…alue Removes default field, relies solr config to define default/search fields for autocomplete url request handler
This was referenced Mar 4, 2019
Tested heavily by @agentrickard in PRs referenced above. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following functionality:
This PR also makes the solr client un-opinionated about default / query fields, relying on the implementation's solr config to set these. This allows flexibility with the default search, autocomplete, and enables field boosting to be set in solr config.
Main and autocomplete queries are now sent with
q=<mainQueryField.value>
as opposed toq=tm_rendered_item:<mainQueryField.value>
andq=<mainQueryField.value>+<mainQueryField.value>*&df=mainQueryField.field
respectively.To test
yarn test
, observe that all tests passbuildSuggestQuery
,solrSuggestQuery
,suggestQueryReducer
,suggestionsReducer
for a high level understanding of what the new code does (as of now, this will likely change a bit this week)TODO