Merge pull request #74 from palantirnet/configurable-settings-destina…

…tion

Allow building settings.php to different destinations.

docs/properties.md

@@ -35,7 +35,9 @@ Cool! This phing-ism is what powers our environment-specific property layering a
 | `build.artifact_mode` | `symlink` | Whether to `symlink` or `copy` assets like CSS, JS, and other code during the build. |
 | `build.test_output` | `/dev/null` | Where to output reports from tests. On Circle, try `${env.CIRCLE_TEST_REPORTS}`. |
 | `build.drupal.settings` | `conf/drupal/settings.php` | Source template for Drupal's `settings.php` file. |
+| `build.drupal.settings_dest` | `web/sites/default/settings.php` | Destination for the templated settings.php file. |
 | `build.drupal.services` | `conf/drupal/services.yml` | Source template for Drupal's `services.yml` file. |
+| `build.drupal.services_dest` | `web/sites/default/services.yml` | Destination for the templated `services.yml` file. |
 
 
 ### Drupal

tasks/drupal.xml

@@ -41,7 +41,9 @@
     <property name="drupal.twig.debug" value="false" />
     <property name="drupal.config_sync_directory" value="../conf/drupal/config" /> <!-- pantheon = private/config -->
     <property name="build.drupal.settings" value="conf/drupal/settings.php" />
+    <property name="build.drupal.settings_dest" value="${drupal.root}/sites/${drupal.sites_subdir}/settings.php" />
     <property name="build.drupal.services" value="conf/drupal/services.yml" />
+    <property name="build.drupal.services_dest" value="${drupal.root}/sites/${drupal.sites_subdir}/services.yml" />
 
     <!-- These properties will generally not change. -->
     <property name="drupal.sites_subdir" value="default" /> <!-- Directory within 'sites' dir in the drupal root -->
@@ -143,11 +145,10 @@
 
     <!-- Target: drupal-prepare-settings -->
     <target name="drupal-prepare-settings">
-        <fail unless="drupal.root" />
-        <fail unless="drupal.sites_subdir" />
         <fail unless="build.drupal.settings" />
+        <fail unless="build.drupal.settings_dest" />
 
-        <copy file="${build.dir}/${build.drupal.settings}" tofile="${build.dir}/${drupal.root}/sites/${drupal.sites_subdir}/settings.php" overwrite="true" mode="555">
+        <copy file="${build.dir}/${build.drupal.settings}" tofile="${build.dir}/${build.drupal.settings_dest}" overwrite="true" mode="555">
             <filterchain>
                 <expandproperties />
             </filterchain>
@@ -157,11 +158,10 @@
 
     <!-- Target: drupal-prepare-services -->
     <target name="drupal-prepare-services">
-        <fail unless="drupal.root" />
-        <fail unless="drupal.sites_subdir" />
         <fail unless="build.drupal.services" />
+        <fail unless="build.drupal.services_dest" />
 
-        <copy file="${build.dir}/${build.drupal.services}" tofile="${build.dir}/${drupal.root}/sites/${drupal.sites_subdir}/services.yml" overwrite="true" mode="644">
+        <copy file="${build.dir}/${build.drupal.services}" tofile="${build.dir}/${build.drupal.services_dest}" overwrite="true" mode="644">
             <filterchain>
                 <expandproperties />
             </filterchain>