Merge pull request #87 from palantirnet/remove-old-dependencies

Remove old dependencies for Drupal 8.4.0 compatibility

build.dist.xml

@@ -42,7 +42,6 @@
         <phing phingfile="${build.dir}/vendor/palantirnet/the-build/tasks/code_review/drupal_code_sniffer.xml" />
         <phing phingfile="${build.dir}/vendor/palantirnet/the-build/tasks/code_review/phpmd.xml" />
         <phing phingfile="${build.dir}/vendor/palantirnet/the-build/tasks/code_review/phplint.xml" />
-        <phing phingfile="${build.dir}/vendor/palantirnet/the-build/tasks/code_review/phptodo.xml" />
     </target>
 
 

composer.json

@@ -14,7 +14,7 @@
     "require": {
         "continuousphp/phing-drush-task": "dev-master",
         "drupal/coder": "*",
-        "nilportugues/php_todo": "^1.0",
+        "drush/drush": "^8.1.15",
         "pear/versioncontrol_git": "@dev",
         "phing/phing": "^2.14",
         "phpmd/phpmd": "^2.4",

docs/code_review.md

@@ -7,7 +7,6 @@ This will review your code with:
 * Drupal Codesniffer
 * PHPmd
 * PHP Lint
-* PHPtodo
 
 Generally, you should configure your `build.xml` to run code reviews as part of your `test` target so that developers run the reviews by default.
 
@@ -50,13 +49,5 @@ By default, when Codesniffer finds problems it will throw an error. If you must,
 drupal_code_sniffer.haltonerror=false
 ```
 
-### [PHP To-do Finder](https://github.com/nilportugues/php-todo-finder)
-
-Sets a threshold for the number of "to do" comments allowable in a codebase. The default config for this review can be found within the-build at `conf/php_todo_finder.yml`. To customize this config, copy that file to your project's `conf/` directory and add the build property:
-
-```
-phptodo.config=conf/php_todo_finder.yml
-```
-
 ----
-Copyright 2016 Palantir.net, Inc.
+Copyright 2017 Palantir.net, Inc.

docs/properties.md

@@ -68,7 +68,6 @@ Cool! This phing-ism is what powers our environment-specific property layering a
 |---|---|---|
 | `phpmd.rulesets` | `vendor/palantirnet/the-build/conf/phpmd.xml` | Relative path to the PHPMD configuration. |
 | `drupal_code_sniffer.standard` | `vendor/drupal/coder/coder_sniffer/Drupal/ruleset.xml` | Relative path the the Drupal codesniffer standard. |
-| `phptodo.config` | `conf/php_todo_finder.yml` | Relative path to the PHP To-do Finder configuration. |
 
 [More info](code_review.md)