Skip to content

Commit

Permalink
Merge pull request #148 from palantirnet/coder-8-3-7
Browse files Browse the repository at this point in the history
Use extension list instead of ignore for phpcs
  • Loading branch information
becw authored Jan 27, 2020
2 parents d157ac7 + 6bc26a0 commit 6b42c47
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions defaults.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,14 @@ phpcs:

# Comma-separated list of patterns for files and directories to exclude from the
# PHP_CodeSniffer review.
#
# This is deprecated and will be removed in 3.0, and build.xml will need to be updated then to
# use the extensions option (below). This option should not be used with Coder >= 8.3.7, which only
# checks php, inc, css, and js by default.
ignore: "*.md"

# Comma-separated list of extensions to check in the PHP_CodeSniffer review.
extensions: "php,module,inc,install,test,profile,theme,css,info,txt,yml,js"


# Configuration for using PHP Mess Detector to check for general PHP best practices,
Expand Down
2 changes: 1 addition & 1 deletion defaults/install/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
</phplint>

<!-- Run PHP Code Sniffer. -->
<property name="phpcs.command" value="vendor/bin/phpcs --standard=${phpcs.standard} --ignore=${phpcs.ignore} ${phpcs.directories}" />
<property name="phpcs.command" value="vendor/bin/phpcs --standard=${phpcs.standard} --extensions=${phpcs.extensions} ${phpcs.directories}" />
<echo msg="$> ${phpcs.command}" />
<exec command="${phpcs.command}" logoutput="true" checkreturn="true" />

Expand Down

0 comments on commit 6b42c47

Please sign in to comment.