Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable render cache for development #107

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

becw
Copy link
Member

@becw becw commented Oct 17, 2018

Addresses #20.

This file (drupal.settings.build.php) is only used on local and CI environments. Acquia, Pantheon, and Platform.sh environments use an entirely separate settings file template.

@becw becw added this to the 2.0 milestone Oct 17, 2018
@becw becw requested review from froboy and byrond October 17, 2018 22:56
@froboy
Copy link
Contributor

froboy commented Oct 18, 2018

@becw thanks for getting this in! Let me talk this through with myself for a bit...

Eyeballing the code, it looks like this doesn't i want to confirm this addresses twig auto-reload and caching. I think those are being set in default.services.build.yml.

I just looked in default.services.yml from core and something new caught my eye: If you don't provide a value for auto_reload, it will be determined based on the value of debug. So, the default state of auto_reload: null and cache: true should give us what we need?

I tested this config on NTC, and it seems so...

  twig.config:
    debug: true
    auto_reload: null
    cache: true

seems like it gives all the auto-reload functionality we need to not have to drush cr to the end of time. 🎉

Copy link
Contributor

@froboy froboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. Looks like this is a functional and very elegant solution.

@becw
Copy link
Member Author

becw commented Oct 18, 2018

Awesome, thanks for checking this out! I followed the docs :)

@becw becw merged commit 81c75a4 into release-2.0 Oct 18, 2018
@becw becw deleted the disable-render-cache branch October 18, 2018 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants