Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keeping the result of an artifact build without cleaning it up #115

Merged
merged 6 commits into from
Nov 20, 2018

Conversation

becw
Copy link
Member

@becw becw commented Nov 14, 2018

Addresses #109.

I had to fix two bugs while working on this:

Other than that, this changes the artifact build process so that instead of prompting the user with Push artifact changes to the '${artifact.git.remote_branch}' branch? y,n, it offers this prompt:

Push artifact changes to the 'artifact-test' branch?
  0: push
  1: keep
  2: discard
 [0]

This defaults to pushing if you hit enter.

  • push pushes the artifact to the remote
  • keep doesn't push, but leaves the generated artifact in place so that you can examine it
  • discard reverts to the previous version of the artifact

@becw
Copy link
Member Author

becw commented Nov 20, 2018

Merging this in order to get these bugfixes, and cut another alpha tag.

@becw becw merged commit 7afd060 into release-2.0 Nov 20, 2018
@becw becw deleted the keep-artifact branch November 20, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants