Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install drupal-check on circle #153

Merged
merged 4 commits into from
Apr 30, 2020
Merged

install drupal-check on circle #153

merged 4 commits into from
Apr 30, 2020

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Apr 14, 2020

  • Removes the drupal-check installation step from the CircleCI config that tests The Build itself.
  • Adds a step in the CircleCI config template to install drupal-check.
  • Matches the installation method for drupal-check with The Vagrant. Installing via Composer can lead to issues as dependencies change. For example:
     [exec]  ------ --------------------------------------------------------------
     [exec]          Internal error: Call to undefined method
     [exec]          PhpParser\Comment\Doc::getEndLine()
     [exec]          Run PHPStan with --debug option and post the stack trace to:
     [exec]          https://github.com/phpstan/phpstan/issues/new
     [exec]  ------ --------------------------------------------------------------

See https://github.com/palantirnet/the-build/pull/133/files#diff-1d37e48f9ceff6d8030570cd36286a61 and palantirnet/drupal-skeleton#109

@byrond byrond self-assigned this Apr 14, 2020
@byrond byrond requested a review from becw April 14, 2020 19:14
@becw
Copy link
Member

becw commented Apr 15, 2020

@becw becw merged commit add72bf into develop Apr 30, 2020
@becw becw deleted the install-drupal-check-circle branch April 30, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants