Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates phpcs config in defaults.yml #183

Closed
wants to merge 4 commits into from
Closed

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Feb 2, 2022

@byrond byrond requested a review from becw February 2, 2022 19:38
@byrond byrond self-assigned this Feb 2, 2022
@byrond byrond marked this pull request as draft February 2, 2022 19:49
@byrond
Copy link
Contributor Author

byrond commented Feb 2, 2022

Fooey! I actually found that I needed the --ignore option for a module that will include a vendor and node_modules directory. I'm going to rework this to add the option back in and use it in build.xml.

@byrond
Copy link
Contributor Author

byrond commented Feb 2, 2022

Never mind! I can just move my code-review step earlier in the build, so there are no vendor and node_modules directories to be scanned.

@byrond
Copy link
Contributor Author

byrond commented Feb 2, 2022

Argh. I think I'm switching sides again and saying we could use this. Moving the code-review step works for CircleCI, but during development, if your module has Composer or Node dependencies, they will need to be ignored.

@becw
Copy link
Member

becw commented Mar 11, 2022

Another option here would be to provide a default phpcs.xml file, and remove all of the customized phpcs config and commands from the-build. That way, the build.xml file could run phpcs without arguments, developers could easily run the same phpcs config by running phpcs directly, and it would be more obvious that phpcs was set up for a project...

@becw
Copy link
Member

becw commented Oct 6, 2022

I merged #185 instead.

@becw becw closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--ignore flag for phpcs is documented in defaults.yml but not used by default in build.xml
2 participants