Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for Composer files in styleguide #187

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Mar 31, 2022

Our styleguide starter kit doesn't include composer.*, and the build looks for them by default in order to determine if the styleguide exists. Traditionally, a workaround has been to override this target in a project's build.xml and remove the check for those files. Going forward, it seems we no longer need the check in the-build's version of styleguide-exists.

The drawback to this would be for projects that update to a version of the-build with this change but still have composer.* in their styleguide would no longer check for the existence of those files. That doesn't seem to be an issue, unless a project was relying on the absence of composer.* to skip the styleguide build.

@byrond byrond self-assigned this Mar 31, 2022
@becw becw merged commit cc82b76 into develop Oct 6, 2022
@becw becw deleted the update-styleguide-exists branch October 6, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants