Remove check for Composer files in styleguide #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our styleguide starter kit doesn't include
composer.*
, and the build looks for them by default in order to determine if the styleguide exists. Traditionally, a workaround has been to override this target in a project'sbuild.xml
and remove the check for those files. Going forward, it seems we no longer need the check in the-build's version ofstyleguide-exists
.The drawback to this would be for projects that update to a version of the-build with this change but still have
composer.*
in their styleguide would no longer check for the existence of those files. That doesn't seem to be an issue, unless a project was relying on the absence ofcomposer.*
to skip the styleguide build.