New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix php docker image name in installed circleci config #188

Merged

byrond merged 1 commit into develop from fix-php-docker-image-name

Jun 10, 2022

Contributor

byrond commented May 26, 2022

The node-browsers variant no longer exists, so switch to just browsers. If Node.js is required, use the orb:
https://circleci.com/developer/orbs/orb/circleci/node

Testing steps:

Add the-build into a project using this branch: composer require palantirnet/the-build:dev-fix-php-docker-image-name
Run the installer: vendor/bin/the-build-installer
Verify the Docker image name in .circleci/config.yml is correct.


          fix php docker image name in installed circleci config

f19157d

byrond self-assigned this

byrond merged commit b1f0714 into develop

byrond deleted the fix-php-docker-image-name branch

June 10, 2022 15:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet