-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TECH-33 Copy phpcs.xml to different path depending on host #211
TECH-33 Copy phpcs.xml to different path depending on host #211
Conversation
I don't think I adequately described what we need here. We actually need to modify the contents of: Specifically, we need to change these lines in the file when the web root is changed from the-build/defaults/install/phpcs.xml Lines 32 to 33 in fc7b0ff
The file should always be copied to the project root. See the following example: In the above example, we are updating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you!
Overview
Modifies
phpcs.xml
install location for pantheon builds.Jira ticket
Testing
I tested this using the following steps:
git clone https://github.com/palantirnet/drupal-skeleton.git
cd drupal-skeleton
composer install
cd vendor/palantirnet && rm -rf the-build
git clone https://github.com/palantirnet/the-build.git
cd the-build
git checkout --track origin/TECH-33-update-phpcs-xml-during-the-build-install
ddev start
ddev ssh
vendor/bin/the-build-installer
pantheon
as the hosting platform.phpcs.xml
has the following lines:acquia
as the hosting platform.phpcs.xml
has the following lines: