New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-36: The Build removed phpcbf settings #221

Merged

byrond merged 1 commit into develop from DEV-36-phpcbf

May 4, 2023

Contributor

agentrickard commented May 3, 2023

DEV-36: The Build removed phpcbf settings(https://palantir.atlassian.net/browse/DEV-36)

When we updated the phpcs command to use phpcs.xml, we left in the old config for code-fix (which was removed from build.yml)
This PR runs the correct command now, since passing empty values causes the entire code base to be checked.


          phpcbf uses phpcs.xml now

12625f0

agentrickard requested a review from byrond

May 3, 2023 18:51

agentrickard added the Ready for Review label

byrond approved these changes

View reviewed changes

byrond merged commit ffd9162 into develop

byrond deleted the DEV-36-phpcbf branch

May 4, 2023 15:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Review