DEV-37: Lint custom javascript with eslint #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
jesconstantine
commented
Jun 7, 2023
… options" This reverts commit 53cbedb.
https://docs.acquia.com/cloud-platform/performance/memcached/enable/ The old file is no longer available and causes the-build-installer to fail
we add it to the new eslint task instead
This was a temporary and unnecessary change
jesconstantine
commented
Jul 13, 2023
targets/install.xml
Outdated
Comment on lines
283
to
290
| <httpget url="https://docs.acquia.com/_downloads/cloud-memcache-d8+.php" dir="${build.dir}/${drupal.root}/sites/${drupal.site.dir}" filename="settings.acquia-memcache.php"/> | ||
| <composer command="require" composer="${composer.composer}"> | ||
| <arg line="--working-dir ${application.startdir}"/> | ||
| <arg value="drupal/memcache"/> | ||
| </composer> | ||
| <composer command="require" composer="${composer.composer}"> | ||
| <arg line="--working-dir ${application.startdir}"/> | ||
| <arg value="acquia/memcache-settings"/> | ||
| </composer> |
There was a problem hiding this comment.
We can roll this back once #226 is merged but this unblocks the build installer test step.
For example, custom modules might come with their own eslint setup.
patrickfweston
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
code-reviewtargetcode-reviewtarget.jsfiles fromphpmd.xmlto ensure PHP linters are linting js filesTest this PR with palantirnet/drupal-skeleton#146