Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-42 - Drop database tables when running load-db. #228

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

raylwalters
Copy link
Contributor

@raylwalters raylwalters commented Sep 29, 2023

This work drops the database tables when running drupal-load-db.

Testing Instructions

  1. In a project checkout this branch for the-build "palantirnet/the-build": "dev-dev-42-drupal-load-db"
  2. composer up palantirnet/the-build
  3. SSH into ddev ddev ssh
  4. Run phing load and verify that drupal-load-db runs drush sql-drop -y

@raylwalters
Copy link
Contributor Author

I believe this is failing code review because of Can't find the custom report class: defaults/standard/phpmd.xml which might be related to https://palantir.atlassian.net/browse/DEV-30?

@raylwalters
Copy link
Contributor Author

This is now passing code review after pinning phpmd to 2.13.

Copy link
Contributor

@jaymejohnson jaymejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Screenshot 2023-11-15 at 1 18 28 PM

@becw becw merged commit c7c947f into develop Nov 16, 2023
@becw becw deleted the dev-42-drupal-load-db branch November 16, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants