Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin phpmd version #232

Merged
merged 5 commits into from
Nov 29, 2023
Merged

unpin phpmd version #232

merged 5 commits into from
Nov 29, 2023

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Nov 17, 2023 •
edited
Loading

Versions of phpmd greater than 2.13 require the --suffixes flag. We pinned to 2.13 until we figured this out. This removes the constraint and allows 2.14 and later to be installed while fixing the calls to phpmd in the-build.

@byrond byrond self-assigned this Nov 17, 2023
@byrond byrond mentioned this pull request Nov 17, 2023
Closed
becw
becw approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@becw becw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The updated usage of the phpmd command works under phpmd 2.13 AND 2.14, nifty.

@becw becw merged commit 9cca1b6 into develop Nov 29, 2023
@becw becw deleted the unpin-phpmd-version branch November 29, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becw becw becw approved these changes

Assignees

@byrond byrond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byrond @becw