DEV-49: Add behat features directory to phpcs linting. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raylwalters
approved these changes
Jan 19, 2024
|
Rerunning CI after the related PR was merged in palantirnet/drupal-skeleton makes the tests pass, so I'm going to force merge this. |
|
The passing pipeline that GitHub does not recognize: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds features/bootstrap to the list of directories to be scanned so we can test the code in our custom contexts.
Testing:
Spin up a site that has behat testing set up
composer require this version of the_build
run
ddev phing code-reviewand verify that the test scans the features directory.This addresses both https://palantir.atlassian.net/browse/DEV-56 and https://palantir.atlassian.net/browse/DEV-49.