Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the 'drupal.modules_enable' property/behavior #94

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Remove the 'drupal.modules_enable' property/behavior #94

merged 2 commits into from
Sep 12, 2018

Conversation

becw
Copy link
Member

@becw becw commented Aug 23, 2018

Remove the 'drupal.modules_enable' property -- sites should use config_split instead.

@becw becw requested a review from byrond August 23, 2018 00:47
byrond
byrond reviewed Aug 23, 2018
View reviewed changes
Copy link
Contributor

@byrond byrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Should we add a "deprecated" notice in case projects that use it have their version of the-build udated?

@becw
Copy link
Member Author

becw commented Sep 5, 2018

Oh, that's a good idea.

@becw
Copy link
Member Author

becw commented Sep 6, 2018

@byrond I've added deprecation messages -- is that text helpful, or is there some other info I should add?

byrond
byrond approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@byrond byrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, @becw!

@becw becw merged commit 0479517 into release-1.0 Sep 12, 2018
@becw becw deleted the deprecate-modules-enable branch September 12, 2018 16:00
becw added a commit that referenced this pull request Sep 13, 2018
@becw
Remove deprecation warnings from PR #94.
cb39642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrond byrond byrond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@becw @byrond