This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
Generate better self-signed certs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becw
reviewed
Jul 9, 2018
| # The extentions to add to a self-signed cert | ||
| subjectKeyIdentifier = hash | ||
| basicConstraints = critical,CA:false | ||
| subjectAltName = DNS:{{ hostname }},DNS:www.{{ hostname }} |
There was a problem hiding this comment.
Should this line include *.{{ hostname }}?
Also, should we pass the extra_hostnames array through to Ansible in the Vagrantfile, and include those here?
There was a problem hiding this comment.
I'm not sure if * would work, but that's definitely possible. I forgot about extra_hostnames... we might need to do some processing to prefix them all with DNS: but if you can do that easily that'd be awesome.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://security.stackexchange.com/a/166645.
To test:
ansible_https_enabled = truevagrant reload --provision
- follow these instructions https://deliciousbrains.com/https-locally-without-browser-privacy-errors/#installing-certificate to locally trust the certificate - refresh the page and observe GREEN!