Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from upstream master branch #5

Open
wants to merge 4 commits into
base: abstract-signaling-server
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "y-webrtc",
"version": "10.2.6",
"version": "10.3.0",
"description": "WebRTC provider for Yjs",
"type": "module",
"main": "./dist/y-webrtc.cjs",
Expand Down
46 changes: 37 additions & 9 deletions src/y-webrtc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as error from 'lib0/error'
import * as random from 'lib0/random'
import * as encoding from 'lib0/encoding'
import * as decoding from 'lib0/decoding'
import { Observable } from 'lib0/observable'
import { ObservableV2 } from 'lib0/observable'
import * as logging from 'lib0/logging'
import * as promise from 'lib0/promise'
import * as bc from 'lib0/broadcastchannel'
Expand Down Expand Up @@ -179,7 +179,7 @@ export class WebrtcConn {
this.connected = false
this.synced = false
/**
* @type {any}
* @type {import('simple-peer').Instance}
*/
this.peer = new Peer({ initiator, ...room.provider.peerOpts })
this.peer.on('signal', signal => {
Expand Down Expand Up @@ -342,9 +342,9 @@ export class Room {
* Listens to Yjs updates and sends them to remote peers
*
* @param {Uint8Array} update
* @param {any} origin
* @param {any} _origin
*/
this._docUpdateHandler = (update, origin) => {
this._docUpdateHandler = (update, _origin) => {
const encoder = encoding.createEncoder()
encoding.writeVarUint(encoder, messageSync)
syncProtocol.writeUpdate(encoder, update)
Expand All @@ -354,9 +354,9 @@ export class Room {
* Listens to Awareness updates and sends them to remote peers
*
* @param {any} changed
* @param {any} origin
* @param {any} _origin
*/
this._awarenessUpdateHandler = ({ added, updated, removed }, origin) => {
this._awarenessUpdateHandler = ({ added, updated, removed }, _origin) => {
const changedClients = added.concat(updated).concat(removed)
const encoderAwareness = encoding.createEncoder()
encoding.writeVarUint(encoderAwareness, messageAwareness)
Expand Down Expand Up @@ -566,13 +566,29 @@ export class SignalingConn extends ws.WebsocketClient {
* @property {awarenessProtocol.Awareness} [awareness]
* @property {number} [maxConns]
* @property {boolean} [filterBcConns]
* @property {any} [peerOpts]
* @property {import('simple-peer').SimplePeer['config']} [peerOpts]
*/

/**
* @extends Observable<string>
* @param {WebrtcProvider} provider
*/
const emitStatus = provider => {
provider.emit('status', [{
connected: provider.connected
}])
}

/**
* @typedef {Object} WebrtcProviderEvents
* @property {function({connected:boolean}):void} WebrtcProviderEvent.status
* @property {function({synced:boolean}):void} WebrtcProviderEvent.synced
* @property {function({added:Array<string>,removed:Array<string>,webrtcPeers:Array<string>,bcPeers:Array<string>}):void} WebrtcProviderEvent.peers
*/

/**
* @extends ObservableV2<WebrtcProviderEvents>
*/
export class WebrtcProvider extends Observable {
export class WebrtcProvider extends ObservableV2 {
/**
* @param {string} roomName
* @param {Y.Doc} doc
Expand Down Expand Up @@ -618,13 +634,23 @@ export class WebrtcProvider extends Observable {
} else {
this.room.disconnect()
}
emitStatus(this)
})
this.connect()
this.destroy = this.destroy.bind(this)
doc.on('destroy', this.destroy)
}

/**
* Indicates whether the provider is looking for other peers.
*
* Other peers can be found via signaling servers or via broadcastchannel (cross browser-tab
* communication). You never know when you are connected to all peers. You also don't know if
* there are other peers. connected doesn't mean that you are connected to any physical peers
* working on the same resource as you. It does not change unless you call provider.disconnect()
*
* `this.on('status', (event) => { console.log(event.connected) })`
*
* @type {boolean}
*/
get connected () {
Expand All @@ -640,6 +666,7 @@ export class WebrtcProvider extends Observable {
})
if (this.room) {
this.room.connect()
emitStatus(this)
}
}

Expand All @@ -654,6 +681,7 @@ export class WebrtcProvider extends Observable {
})
if (this.room) {
this.room.disconnect()
emitStatus(this)
}
}

Expand Down