Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comonads #53

Merged
merged 4 commits into from
Aug 3, 2019
Merged

Comonads #53

merged 4 commits into from
Aug 3, 2019

Conversation

nomicflux
Copy link
Contributor

Initial implementation of Comonads for review and revision

@jnape
Copy link
Member

jnape commented Jun 4, 2019

This PR is so high-quality it nearly brings me to tears. Let me look it over to offer thoughtful feedback, but this is the new gold standard for PRs.

@jnape
Copy link
Member

jnape commented Jun 9, 2019

@nomicflux discovered a bug in the process of putting this PR together in javac that effectively prevents Tuples from being Comonad, related to the same reason #2 isn't yet in lambda. He's already submitted the bug report to Oracle, and I'm going to watch the issue to get a sense of their urgency in addressing it and it's feasibility, and go from there. If it doesn't look good in terms of getting the bug patched anytime soon, I may still just merge this in; it would just be unfortunate to have a situation where Tuples, which are de facto examples of Comonads, not able to be Comonads.

@nomicflux
Copy link
Contributor Author

nomicflux commented Jun 10, 2019

@jnape jnape changed the base branch from master to comonads August 3, 2019 20:29
@jnape jnape merged commit 7aaf167 into palatable:comonads Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants