Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: add query.ALERTS to query the system #118

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

xtimmy86x
Copy link
Contributor

Related Issues

Proposed Changes:

Integrate the actual get_status def into query def under query.ALERTS for better future development

Testing:

Extra Notes (optional):

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change that creates a single API to query the system/cloud! Few small changes and we're good to go!

src/elmo/api/client.py Outdated Show resolved Hide resolved
src/elmo/api/client.py Outdated Show resolved Hide resolved
tests/test_client.py Outdated Show resolved Hide resolved
@palazzem palazzem changed the title refactor:add query.ALERTS refactor!: add query.ALERTS to query the system Oct 12, 2023
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback! we're good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants