Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arm and disarm multiple sectors with one request #128

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

xtimmy86x
Copy link
Contributor

Related Issues

Proposed Changes:

Change how the system send the arm and the disarm request
With this method, we can arm and disarm multiple sectors by sending a single request

Testing:

Extra Notes (optional):

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem self-assigned this Nov 10, 2023
@palazzem palazzem added this to the 0.9.0 milestone Nov 10, 2023
@palazzem palazzem changed the title refactor: arm and disarm multiple sectors with one request fix: arm and disarm multiple sectors with one request Nov 10, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6826878608

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6812007047: 0.0%
Covered Lines: 352
Relevant Lines: 352

💛 - Coveralls

Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! That's a small change with a great impact! Thanks for improving the code!

@palazzem palazzem merged commit bd81d86 into palazzem:main Nov 10, 2023
@xtimmy86x xtimmy86x deleted the xtimmy86x/refactor-arm-disarm branch November 10, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants