Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add missing keys for q.OUTPUTS queries #130

Merged
merged 3 commits into from
Nov 21, 2023
Merged

feat!: add missing keys for q.OUTPUTS queries #130

merged 3 commits into from
Nov 21, 2023

Conversation

xtimmy86x
Copy link
Contributor

Related Issues

Proposed Changes:

Revise the structure of the query result by incorporating additional keys that are currently absent.

Testing:

Extra Notes (optional):

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@xtimmy86x xtimmy86x marked this pull request as ready for review November 19, 2023 15:23
@palazzem palazzem self-requested a review November 21, 2023 09:26
@palazzem palazzem added this to the 0.9.0 milestone Nov 21, 2023
palazzem
palazzem requested changes Nov 21, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change on the naming and we should be good to go!

src/elmo/api/client.py Outdated Show resolved Hide resolved
src/elmo/api/client.py Show resolved Hide resolved
palazzem
palazzem approved these changes Nov 21, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6944610770

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6913072498: 0.0%
Covered Lines: 389
Relevant Lines: 389
💛 - Coveralls

@palazzem palazzem changed the title refactor:add missing keys in query feat!: add missing keys for q.OUTPUTS queries Nov 21, 2023
@palazzem palazzem merged commit 78b236e into palazzem:main Nov 21, 2023
3 checks passed
@xtimmy86x xtimmy86x deleted the xtimmy86x/refactor-query branch November 21, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees

@palazzem palazzem

@xtimmy86x xtimmy86x

Labels
topic:api type:feature
Projects
e-Connect Roadmap
Archived in project
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xtimmy86x @coveralls @palazzem