fix(client): raise InvalidToken
if the token expires while using lock()
#134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
lock()
method uses the@contextmanager
decorator that doesn't propagate inner exception. If a 401 response is received (the token is expired), that error is not propagated above and it causes the token to not get refreshed until the nextpoll()
. In a real scenario where you have delays, it means it's very likely that you can't interact with the system unless you hit the exact window between one refresh and another.Testing:
Acquire a token, let it expire, call
lock()
Extra Notes (optional):
n/a
Checklist