Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lock() accepts an optional userId #142

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

palazzem
Copy link
Owner

@palazzem palazzem commented Feb 2, 2024

Related Issues

Proposed Changes:

Adds user_id optional parameter to lock(). This change adds support for all main units that require the userId parameter during the unit authentication.

Testing:

n/a

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7758596374

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7758383549: 0.0%
Covered Lines: 381
Relevant Lines: 381

💛 - Coveralls

@palazzem palazzem merged commit ad9de56 into main Feb 2, 2024
4 checks passed
@palazzem palazzem deleted the palazzem/feature-141 branch February 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for main units that require the userId code
2 participants