Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): handle main unit disconnections #147

Merged
merged 1 commit into from
Mar 1, 2024
Merged

feat(api): handle main unit disconnections #147

merged 1 commit into from
Mar 1, 2024

Conversation

palazzem
Copy link
Owner

@palazzem palazzem commented Mar 1, 2024

Related Issues

Proposed Changes:

Raises a DeviceDisconnectedError if the main unit is disconnected.

Testing:

Disconnect the unit and call the client.query().

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem added this to the 0.12.0 milestone Mar 1, 2024
@palazzem palazzem self-assigned this Mar 1, 2024
@palazzem palazzem merged commit 5afd849 into main Mar 1, 2024
3 checks passed
@palazzem palazzem deleted the palazzem/feature-139 branch March 1, 2024 11:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8110483046

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7783324941: 0.0%
Covered Lines: 393
Relevant Lines: 393
💛 - Coveralls

@palazzem palazzem mentioned this pull request Mar 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@palazzem palazzem

Labels
topic:api type:feature
Projects
e-Connect Roadmap
Archived in project
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Handle main unit disconnections
2 participants
@palazzem @coveralls