Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing end periods for error messages everywhere #620

Merged
merged 6 commits into from
Jun 15, 2020
Merged

Add missing end periods for error messages everywhere #620

merged 6 commits into from
Jun 15, 2020

Conversation

greyli
Copy link
Member

@greyli greyli commented Jun 15, 2020 •
edited
Loading

Update the error messages in the following positions:

  • Source
  • wtforms.pot file
  • All the raw message (msgid) in 32 translations (.po files)
  • Translated text for English, German, Chinese (both simplified and traditional), Japanese (there are still about 27 translations that need to check and update).

fix #613

@azmeuk
Copy link
Member

azmeuk commented Jun 15, 2020

Thank you for your patch. There is still a test failing though.

@greyli
Copy link
Member Author

greyli commented Jun 15, 2020

I see, will fix it.

@greyli
Copy link
Member Author

greyli commented Jun 15, 2020

Done :)

@azmeuk
Copy link
Member

azmeuk commented Jun 15, 2020

LGTM.

@azmeuk azmeuk merged commit 3c7e1e9 into pallets-eco:master Jun 15, 2020
@greyli greyli deleted the improve-error-messages branch June 15, 2020 15:25
@greyli greyli mentioned this pull request Jun 21, 2020
Merged
@azmeuk azmeuk mentioned this pull request Jun 21, 2020
Merged
pypingou pushed a commit to Pagure/pagure that referenced this pull request Feb 13, 2023
@wombelix
tests: wtforms changed error messages
25091a3 
In wtforms version >= 2.3.2 localizations where unified with ending dots.
From version >=3.0.0 also the english localization was adjusted.
'Not a valid choice' became 'Not a valid choice.', logic added to assert based on version.

References:
pallets-eco/wtforms#613
pallets-eco/wtforms#620
pallets-eco/wtforms@2.3.2...master
pallets-eco/wtforms@514a972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The format of the error messages are not unified (ending period)
2 participants
@greyli @azmeuk