Drop Python 3.8 support #5614
Closed
Drop Python 3.8 support #5614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a failure in the `py38-dev` tests caused by markupsafe recently dropping Python 3.8 support. Changed in this commit: * Drop Python 3.8 support * Update CI and tox testing * Update docs references to Python 3.8 * Remove a Windows / Python 3.8 admonition in the docs * Address type annotations * Incorporate style fixes Still to do: * `src/flask/sessions.py` contains these comments: > TODO generic when Python > 3.8 This TODO should now be unblocked.
|
Rebased on |
|
Closing because #5615 addressed the failing tests. |
|
Thanks for doing the rest of this, I didn't mean to preempt that. |
|
No worries! If you want me to re-submit this PR I can, but I saw the note in #5615 that said the current release series needed to continue supporting Python 3.8 and figured this branch might be premature. Let me know if you want this re-submitted. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a failure in the
py38-devtests caused by markupsafe recently dropping Python 3.8 support. [recent example]Changed in this commit:
Still to do:
src/flask/sessions.pycontains these comments:This TODO should now be unblocked.