Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 support #400

Closed
nth10sd opened this issue Oct 25, 2022 · 2 comments · Fixed by #435
Closed

Python 3.11 support #400

nth10sd opened this issue Oct 25, 2022 · 2 comments · Fixed by #435

Comments

@nth10sd
Copy link

nth10sd commented Oct 25, 2022

Describe the bug

pandas-stubs/pyproject.toml

Line 34 in 581c1eb

python = ">=3.8,<3.11"

Python 3.11 is not supported.

To Reproduce
Try installing in a venv from Python 3.11

Additional context
It seems pandas already has Python 3.11 support.
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Oct 26, 2022 •
edited
Loading

Our tests are failing because pyarrow is used in the testing, and pyarrow doesn't support 3.11 yet.

Also, MacOS doesn't support python 3.11 yet.

PR created: #398

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Oct 31, 2022

Have to wait for mypy 0.990 - see comment here: #398 (review)

@twoertwein twoertwein mentioned this issue Nov 8, 2022
Merged
@Dr-Irv Dr-Irv mentioned this issue Nov 20, 2022
Merged
1 task
jond01 added a commit to jond01/xil that referenced this issue Nov 22, 2022
@jond01
Add mypy to pre-commit and fix the errors
058d6fa 
Limit the Python version to =3.10 because of the
`pandas-stubs` typing dependency, see:
pandas-dev/pandas-stubs#400
Poetry command:
```sh
poetry add -G typing mypy pandas-stubs
```
Add the recommended settings for mypy:
https://blog.wolt.com/engineering/2021/09/30/professional-grade-mypy-configuration/
Fix the errors with type ignore as they originate from
wrong typing in pandas/builtin libs and make sure
mypy passes:
```sh
pre-commit run mypy --all-files
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python 3.11 support Dr-Irv/pandas-stubs
2 participants
@nth10sd @Dr-Irv