Add sample rate to statsd to throttle overexuberant stats #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemiller
reviewed
Oct 24, 2017
| log_print(LOG_DEBUG, SECTION_STATS_DEFAULT, "%s: sample: %.2f, rate: %.2f, send: %d", | ||
| funcname, sample, samplerate, (samplerate > sample)); | ||
| return samplerate > sample; | ||
| } else { |
There was a problem hiding this comment.
just a suggestion: the else is unnecessary here. But if the fusedav codebase currently does this in most places then it probably makes sense to stay consistent
from mozilla coding style guide:
Don't put an else right after a return (or a break). Delete the else, it's unnecessary and increases indentation level.
There was a problem hiding this comment.
OMG. I have scars from all those wars!
|
looks good to me |
jerryblakley
added a commit
that referenced
this pull request
Oct 25, 2017
jerryblakley
added a commit
that referenced
this pull request
Oct 25, 2017
jerryblakley
added a commit
that referenced
this pull request
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.