Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora 28 dev container support (still CircleCI) #522

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Conversation

djschaap
Copy link
Member

@djschaap djschaap commented Nov 16, 2023

  • Add Fedora 28 dev container support.
  • Disable cpplint (during CI/CD) because it has never been enforced anyway.
  • Sort .gitignore.
  • Remove unused scripts/docker-cache.sh.
  • Disable building Fedora 22 packages as they are no longer relevant.

This is meant to be the final CircleCI build of fusedav. The next PR is expected to switch to GitHub Actions.

cpplint was added to CircleCI on 2013-10-14 by commit 7f42dc4 and has
NEVER been enforced.  Its warnings have added NO obvious value over the
past ten years.
- remove .vscode/
- add (ignore) vim swap files
- add (ignore) new-version.sh (for later use)
- sort
Copy link

guardrails bot commented Nov 16, 2023

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@djschaap djschaap marked this pull request as ready for review November 16, 2023 22:20
@djschaap djschaap requested a review from a team as a code owner November 16, 2023 22:20
@djschaap djschaap merged commit 2d84616 into master Dec 5, 2023
@djschaap djschaap deleted the devcontainer branch December 5, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants