Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc/admin): return deposit_contract_address for the admin_NodeInfo RPC #12362

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Nov 7, 2024

indent with Geth's rpc, as geth implements EIP-6110 in ethereum/go-ethereum#29431, it will also includes the deposit contract address in the admin_nodeInfo RPC, eg:

 "protocols": {
      "eth": {
        "config": {
          "arrowGlacierBlock": 13773000,
          "berlinBlock": 12244000,
          "byzantiumBlock": 4370000,
          "cancunTime": 1710338135,
          "chainId": 1,
          "constantinopleBlock": 7280000,
          "daoForkBlock": 1920000,
          "daoForkSupport": true,
          "depositContractAddress": "0x00000000219ab540356cbb839cbe05303d7705fa",
          "eip150Block": 2463000,
          "eip155Block": 2675000,
          "eip158Block": 2675000,
          "ethash": {},
          "grayGlacierBlock": 15050000,
          "homesteadBlock": 1150000,
          "istanbulBlock": 9069000,
          "londonBlock": 12965000,
          "muirGlacierBlock": 9200000,
          "petersburgBlock": 7280000,
          "shanghaiTime": 1681338455,
          "terminalTotalDifficulty": 58750000000000000000000,
          "terminalTotalDifficultyPassed": true
        },
        "difficulty": 58750003716598352816469,
        "genesis": "0xd4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3",
        "head": "0x4b60a18825a5d1500e131e3d33d01cceac66e5963aa3c763f923583f86a89c71",
        "network": 1
      }

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, ty

@mattsse mattsse added this pull request to the merge queue Nov 7, 2024
@mattsse mattsse added the A-rpc Related to the RPC implementation label Nov 7, 2024
Merged via the queue into paradigmxyz:main with commit 581cef3 Nov 7, 2024
41 checks passed
@jsvisa jsvisa deleted the admin-missing-deposit-contract branch November 7, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants