Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: can select 'PATH_INFO' as the locking mechanism #20

Merged
merged 3 commits into from
Nov 20, 2017

Conversation

acornforth
Copy link

@acornforth acornforth commented Aug 23, 2017

for cases when REQUEST_URI is too specific for implementation to be feasible (query-string params)
or in cases where query string params may/may not be present, and may not always hold same data.
Suitable for use with 'front-controller' type uris

…hen REQUEST_URI is too specific for implementation to be feasible (querystring params)
@acornforth
Copy link
Author

Hi, I apologise if i haven't followed the usual ettiquette for making pull requests, by not contacting you in the first instance about my feature.
As it happens this modifiaction was essential for a project i'm working on, so I currently have composer loading this module from my forked repo...
I appreciate that dispensing with the QueryString when checking the lock makes this slightly less secure, and so the original behaviour remains the default. However there are situations when locking to the entire URI is not appropriate, so I am sure other users may find this useful.
Regards
Andrew

@paragonie-scott paragonie-scott merged commit 756dc8c into paragonie:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants