fix(liquidation): add verification for weth liquidation (#304)

parallel-finance · Dec 27, 2022 · 6e0dbb9 · 6e0dbb9
1 parent f6d1675
commit 6e0dbb9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/contracts/protocol/libraries/logic/LiquidationLogic.sol b/contracts/protocol/libraries/logic/LiquidationLogic.sol
@@ -354,12 +354,14 @@ library LiquidationLogic {
             collateralReserve,
             DataTypes.ValidateLiquidateERC721Params({
                 liquidationAssetReserveCache: vars.liquidationAssetReserveCache,
+                liquidationAsset: params.liquidationAsset,
                 liquidator: params.liquidator,
                 borrower: params.borrower,
                 globalDebt: vars.userGlobalDebt,
                 actualLiquidationAmount: vars.actualLiquidationAmount,
                 maxLiquidationAmount: params.liquidationAmount,
                 healthFactor: vars.healthFactor,
+                weth: params.weth,
                 priceOracleSentinel: params.priceOracleSentinel,
                 collateralAsset: params.collateralAsset,
                 tokenId: params.collateralTokenId,

diff --git a/contracts/protocol/libraries/logic/ValidationLogic.sol b/contracts/protocol/libraries/logic/ValidationLogic.sol
@@ -669,6 +669,11 @@ library ValidationLogic {
             );
         }
 
+        require(
+            msg.value == 0 || params.liquidationAsset == params.weth,
+            Errors.INVALID_LIQUIDATION_ASSET
+        );
+
         require(
             params.maxLiquidationAmount >= params.actualLiquidationAmount &&
                 (msg.value == 0 || msg.value >= params.maxLiquidationAmount),

diff --git a/contracts/protocol/libraries/types/DataTypes.sol b/contracts/protocol/libraries/types/DataTypes.sol
@@ -242,12 +242,14 @@ library DataTypes {
 
     struct ValidateLiquidateERC721Params {
         ReserveCache liquidationAssetReserveCache;
+        address liquidationAsset;
         address liquidator;
         address borrower;
         uint256 globalDebt;
         uint256 healthFactor;
         address collateralAsset;
         uint256 tokenId;
+        address weth;
         uint256 actualLiquidationAmount;
         uint256 maxLiquidationAmount;
         uint256 auctionRecoveryHealthFactor;