Add electron-edge-js and C# project, update Electron to 22.0.3 and Node to 16.17.1 #5
Conversation
…ectron-edge-js to release/app folder
….17.1, rolled back electron to 22.0.0, fixed path to dlls, fixed path to EdgeJs.dll in csproj, turned off asar, etc
…ronment variables for edge
…g dotnet app path
There was a problem hiding this comment.
Thanks for all your work on this.
There are some files that were specifically removed from the boilerplate which I've added comments. You can't comment non-text files so also remove the 4x electron assets/icon.* files.
And I have one question about require in a TS file.
Also note there is a failing test in GH on MacOS.
src/main/main.ts
Outdated
| const baseNetAppPath = path.join(RESOURCES_PATH, '/c-sharp/bin/Debug/net7.0'); | ||
| process.env.EDGE_USE_CORECLR = '1'; | ||
| process.env.EDGE_APP_ROOT = baseNetAppPath; | ||
| const edge = require('electron-edge-js'); |
There was a problem hiding this comment.
Does this need to be required rather than imported? Linters don't like it, and I vaguely remember some packaging issues or something in the past.
There was a problem hiding this comment.
Edge needs some environment variables before import/require. EDGE_USE_CORECLR is easy to set in package.json in scripts, but EDGE_APP_ROOT points to the build location of the C# project, which I suppose may be different in different contexts. Would it be different if we were developing vs in packaged production? If not, maybe we can figure out putting EDGE_USE_CORECLR somewhere else. The reason I set environment variables here and then required edge instead of importing at the top is that it did the same in the quick start example, and I couldn't think of a better way for now since I don't really know what the project will look like packaged up and cross-platform and such. Are we going to use different build folders for different distributions? Will the folder be different between development and packaged? How do we address this issue in such a way that we can simply import edge at the top and the EDGE_APP_ROOT environment variable is set correctly? If you have thoughts, please share! Otherwise I will look at the mac deployment and see if that sheds any light. Thanks!
There was a problem hiding this comment.
According to the macos build job, the failure was in npm install:
Package mono-2 was not found in the pkg-config search path.
Perhaps you should add the directory containing `mono-2.pc'
to the PKG_CONFIG_PATH environment variable
No package 'mono-2' found
...
gyp: Call to 'pkg-config mono-2 --libs' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
...
An unhandled error occurred inside electron-rebuild
node-gyp failed to rebuild '/Users/runner/work/paranext-core/paranext-core/release/app/node_modules/electron-edge-js'.
For more information, rerun with the DEBUG environment variable set to "electron-rebuild"
ERB is set up so that native module dependencies are
Looks like there are a number of dependencies that we will need to install in order to build electron-edge-js on the various platforms:
https://github.com/agracio/edge-js#building-on-windows
https://github.com/agracio/edge-js#building-on-osx
https://github.com/agracio/edge-js#building-on-linux
Alternatively, we could investigate using the prebuilt versions of the electron-edge-js package included in its package. We would want to figure out how to prevent .erb/scripts/electron-rebuild.js from firing electron-rebuild on electron-edge-js. However, I suspect this could hinder our cross-platform capabilities or future-proofing capabilities. I don't know, though, so maybe it's worth giving a shot! I will investigate. After all, it is rather annoying that people have to download all these dependencies to make electron-edge-js build on their machine. :/
…iew was not working for Tim. Code review - changed eol to lf, removed extraneous files
…te working even on windows
|
Abandoning. See #1 |
4cf4681b Fixed emotion package duplication (#6) c44fb5ce Reworked explanation for package aliases. Also removed note about splitting into its own repo as this problem will not be solved as long as the package used is local a3fa4976 Fixed emotion package duplication f30019b4 Remove papi-components, replace with two libraries (#5) b5d8fd1e remove papi-components, update packages, add platform-bible-utils as external git-subtree-dir: extensions git-subtree-split: 4cf4681b4ae4dbe1958d33dfc72d949021f7f6ae
EdgeLibrary.csproj(mostly from the edge POC) as a starting point for calling C# functionsResolves #1